Re: Verify true root on replicas with amcheck

From: David Steele <david(at)pgmasters(dot)net>
To: godjan • <g0dj4n(at)gmail(dot)com>
Cc: Peter Geoghegan <pg(at)bowt(dot)ie>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Verify true root on replicas with amcheck
Date: 2020-04-08 14:26:38
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 1/16/20 7:40 PM, Peter Geoghegan wrote:
> On Thu, Jan 9, 2020 at 12:55 AM godjan • <g0dj4n(at)gmail(dot)com> wrote:
>> I heard that amcheck has an invariant about locking no more than 1 page at a moment for avoiding deadlocks. Is there possible a deadlock situation?
> This is a conservative principle that I came up with when I wrote the
> original version of amcheck. It's not strictly necessary, but it
> seemed like a good idea. It should be safe to "couple" buffer locks in
> a way that matches the B-Tree code -- as long as it is thought through
> very carefully. I am probably going to relax the rule for one specific
> case soon -- see:
> Your patch looks like it gets it right (it won't deadlock with other
> sessions that access the metapage), but I hesitate to commit it
> without a strong justification. Acquiring multiple buffer locks
> concurrently is worth avoiding wherever possible.

I have marked this patch Returned with Feedback since it has been
sitting for a while with no response from the author.


In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Julien Rouhaud 2020-04-08 14:37:45 Re: Feature improvement: can we add queryId for pg_catalog.pg_stat_activity view?
Previous Message Mahendra Singh Thalor 2020-04-08 14:24:49 Re: Vacuum o/p with (full 1, parallel 0) option throwing an error