Re: pgbench - add \if support

From: "Daniel Verite" <daniel(at)manitou-mail(dot)org>
To: "Fabien COELHO" <coelho(at)cri(dot)ensmp(dot)fr>
Cc: "Andres Freund" <andres(at)anarazel(dot)de>,"Vik Fearing" <vik(dot)fearing(at)2ndquadrant(dot)com>,"PostgreSQL Developers" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgbench - add \if support
Date: 2018-03-01 16:57:22
Message-ID: 35b0d650-f6d4-4337-8fe0-46d201d75a82@manitou-mail.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Fabien COELHO wrote:

> There does not seem to be any on my side:
>
> sh> hexdump pgbench-if-6.patch | grep '0[ad]' | head -3
> 0000040 6562 636e 2e68 6773 6c6d 690a 646e 7865
> 0000060 2031 3031 3630 3434 2d0a 2d2d 6120 642f
> 0000080 6770 6562 636e 2e68 6773 6c6d 2b0a 2b2b

FYI when looking at the corresponding raw mailfile as we
subscribers receive it, here's what I got:

(for Message-ID: <alpine(dot)DEB(dot)2(dot)20(dot)1801151827260(dot)11126(at)lancre>)

==== start of raw mailfile excerpt ====
Here is a very minor rebase.

--
Fabien.
--8323329-978247287-1516037290=:11126
Content-Type: text/x-diff; name=pgbench-if-6.patch
Content-Transfer-Encoding: BASE64
Content-ID: <alpine(dot)DEB(dot)2(dot)20(dot)1801151828090(dot)11126(at)lancre>
Content-Description:
Content-Disposition: attachment; filename=pgbench-if-6.patch

ZGlmZiAtLWdpdCBhL2RvYy9zcmMvc2dtbC9yZWYvcGdiZW5jaC5zZ21sIGIv
ZG9jL3NyYy9zZ21sL3JlZi9wZ2JlbmNoLnNnbWwNCmluZGV4IDNkZDQ5MmMu
LmMyMDNjNDEgMTAwNjQ0DQotLS0gYS9kb2Mvc3JjL3NnbWwvcmVmL3BnYmVu
Y2guc2dtbA0KKysrIGIvZG9jL3NyYy9zZ21sL3JlZi9wZ2JlbmNoLnNnbWwN
CkBAIC04OTUsNiArODk1LDIxIEBAIHBnYmVuY2ggPG9wdGlvbmFsPiA8cmVw
bGFjZWFibGU+b3B0aW9uczwvcmVwbGFjZWFibGU+IDwvb3B0aW9uYWw+IDxy
==== cut here ====

Now this base64 part piped through `base64 -d` and then `hexdump -C`
gives:
00000000 64 69 66 66 20 2d 2d 67 69 74 20 61 2f 64 6f 63 |diff --git
a/doc|
00000010 2f 73 72 63 2f 73 67 6d 6c 2f 72 65 66 2f 70 67
|/src/sgml/ref/pg|
00000020 62 65 6e 63 68 2e 73 67 6d 6c 20 62 2f 64 6f 63 |bench.sgml
b/doc|
00000030 2f 73 72 63 2f 73 67 6d 6c 2f 72 65 66 2f 70 67
|/src/sgml/ref/pg|
00000040 62 65 6e 63 68 2e 73 67 6d 6c 0d 0a 69 6e 64 65
|bench.sgml..inde|
00000050 78 20 33 64 64 34 39 32 63 2e 2e 63 32 30 33 63 |x
3dd492c..c203c|
00000060 34 31 20 31 30 30 36 34 34 0d 0a 2d 2d 2d 20 61 |41 100644..---
a|
00000070 2f 64 6f 63 2f 73 72 63 2f 73 67 6d 6c 2f 72 65
|/doc/src/sgml/re|
00000080 66 2f 70 67 62 65 6e 63 68 2e 73 67 6d 6c 0d 0a
|f/pgbench.sgml..|
00000090 2b 2b 2b 20 62 2f 64 6f 63 2f 73 72 63 2f 73 67 |+++
b/doc/src/sg|
000000a0 6d 6c 2f 72 65 66 2f 70 67 62 65 6e 63 68 2e 73
|ml/ref/pgbench.s|
000000b0 67 6d 6c 0d 0a 40 40 20 2d 38 39 35 2c 36 20 2b |gml..@@ -895,6
+|

Line endings are already 0d 0a at this point, which normally means
that they were like that in the mail as you submitted it.

Best regards,
--
Daniel Vérité
PostgreSQL-powered mailer: http://www.manitou-mail.org
Twitter: @DanielVerite

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Hartmut Holzgraefe 2018-03-01 16:58:34 Re: zheap: a new storage format for PostgreSQL
Previous Message Alexander Kuzmenkov 2018-03-01 16:56:20 Re: [patch] BUG #15005: ANALYZE can make pg_class.reltuples inaccurate.