From: | "Thomas G(dot) Lockhart" <lockhart(at)alumni(dot)caltech(dot)edu> |
---|---|
To: | Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us> |
Cc: | "Dr(dot) Michael Meskes" <meskes(at)online-club(dot)de>, pgsql-hackers(at)postgreSQL(dot)org |
Subject: | Re: [HACKERS] Bug in gram.y? |
Date: | 1998-08-04 02:10:02 |
Message-ID: | 35C66D7A.D614E4C7@alumni.caltech.edu |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> > it seems that it doesn't accept a createdb with the
> > option location = ... but without the option encoding = ...
I think the code is sub-optimal for a couple of reasons:
1) LOCATION must be the first argument, ENCODING must be the second. The
number and order of any options should be flexible.
2) the options should have a comma delimiter between them. Currently
they do not. To introduce the comma delimiter will require restructuring
that part of the parsing, but isn't a big deal.
I'm pretty sure that the options can be specified individually, but it
does not generalize well. The two specific problems above should be
considered fatal for a final version :/
I've worked through problems like this for other SQL92 syntax, and can
probably fix up this one too. Will put it on my list unless someone else
wants it...
- Tom
From | Date | Subject | |
---|---|---|---|
Next Message | t-ishii | 1998-08-04 02:31:40 | Re: [HACKERS] Bug in gram.y? |
Previous Message | Roland Roberts | 1998-08-03 22:54:48 | PostgreSQL catalogues: finding the primary key |