| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Julien Rouhaud <rjuju123(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Use MaxLockMode in lock methods initialization |
| Date: | 2022-01-03 17:27:18 |
| Message-ID: | 3597997.1641230838@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Mon, Jan 03, 2022 at 02:47:22PM +0800, Julien Rouhaud wrote:
>> While reading some code around I noticed that b04aeb0a053e7 added a MaxLockMode
>> but didn't update the lock methods initialization. It shouldn't make much
>> difference in the long run but some consistency seems better to me.
> Makes sense to me. MaxLockMode is here for the same purpose as this
> initialization area.
Agreed. That aspect of b04aeb0a053e7 was a bit of a quick hack,
and it didn't occur to me to look for other places where the symbol
could be used. But these two places are spot-on for it.
Pushed with a bit of comment-fiddling.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2022-01-03 17:36:05 | Re: [PoC] Delegating pg_ident to a third party |
| Previous Message | Jacob Champion | 2022-01-03 17:24:19 | Re: Proposal: sslmode=tls-only |