Re: Fix inconsistencies with code and beautify xlog structures description and fin hash_xlog.h

From: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
To: Kirill Reshke <reshkekirill(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Fix inconsistencies with code and beautify xlog structures description and fin hash_xlog.h
Date: 2025-09-10 12:36:48
Message-ID: 3594FC75-3A56-45C6-8648-8805A8B4D7CD@yandex-team.ru
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 5 Sep 2025, at 11:24, Kirill Reshke <reshkekirill(at)gmail(dot)com> wrote:
>
> PFA v2

Proposed change is correct and in line with a description of e.g. XLOG_HASH_MOVE_PAGE_CONTENTS.
I'd note that block is for lock only and record does not include image, but other such cases are not reported in comments.

Best regards, Andrey Borodin.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Melanie Plageman 2025-09-10 12:41:25 Re: Incorrect logic in XLogNeedsFlush()
Previous Message Chao Li 2025-09-10 12:08:10 Re: allow benign typedef redefinitions (C11)