Re: pub/sub - specifying optional parameters without values.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Zheng Li <zhengli10(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, Peter Smith <smithpb2250(at)gmail(dot)com>
Subject: Re: pub/sub - specifying optional parameters without values.
Date: 2023-01-29 21:36:39
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Zheng Li <zhengli10(at)gmail(dot)com> writes:
> The behavior is due to the following code

Yeah, so you can grep for places that have this behavior by looking
for defGetBoolean calls ... and there are quite a few. That leads
me to the conclusion that we'd better invent a fairly stylized
documentation solution that we can plug into a lot of places,
rather than thinking of slightly different ways to say it and
places to say it. I'm not necessarily opposed to Peter's desire
to fix replication-related commands first, but we have more to do

I'm also not that thrilled with putting the addition up at the top
of the relevant text. This behavior is at least two decades old,
so if we've escaped documenting it at all up to now, it can't be
that important to most people.

I also notice that ALTER SUBSCRIPTION has fully three different
sub-sections with about equal claims on this note, if we're going
to stick it directly into the affected option lists.

That all leads me to propose that we add the new text at the end of
the Parameters <refsect1> in the affected man pages. So about
like the attached. (I left out alter_publication.sgml, as I'm not
sure it needs its own copy of this text --- it doesn't describe
individual parameters at all, just refer to CREATE PUBLICATION.)

regards, tom lane

Attachment Content-Type Size
v3-0001-clarify-behavior-of-specifying-a-parameter-with-n.patch text/x-diff 2.0 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Smith 2023-01-30 00:10:39 Re: Perform streaming logical transactions by background workers and parallel apply
Previous Message Thomas Munro 2023-01-29 18:20:41 Re: lockup in parallel hash join on dikkop (freebsd 14.0-current)