| From: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
|---|---|
| To: | shaobo zhang <zshaoo224(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Fix missing semicolon in pl_gram.y for option_value rule |
| Date: | 2026-06-09 04:51:47 |
| Message-ID: | 355AF12F-82DA-48A1-8B4A-ECC1247653C8@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Jun 5, 2026, at 15:01, shaobo zhang <zshaoo224(at)gmail(dot)com> wrote:
>
> The option_value grammar rule in src/pl/plpgsql/src/pl_gram.y was
> missing a terminating semicolon, which is inconsistent with the style
> used by other rules in the file. While Bison does not require
> semicolons to terminate grammar rules, adding one here improves
> consistency and readability.
> <v1-0001-Fix-missing-semicolon-in-pl_gram.y-for-option_val.patch>
I would not call this a “fix” as it doesn’t fix anything not working today. It is actually a grammar-style cleanup. Since the code being changed is 12 years old, I think this patch is a candidate for v20.
Would you please add it to the CommitFest so that it can be noticed after v20 opens?
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | shveta malik | 2026-06-09 05:22:50 | Re: DOCS - Add missing EXCEPT parameter description to ALTER PUBLICATION |
| Previous Message | Ayush Tiwari | 2026-06-09 04:46:37 | Re: Remove the refint contrib module (for v20) |