| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Jacob Champion <jchampion(at)timescale(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Gareth Palmer <gareth(dot)palmer3(at)gmail(dot)com>, Richard Guo <guofenglinux(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Ekaterina Sokolova <e(dot)sokolova(at)postgrespro(dot)ru>, Alexander Pyhalov <a(dot)pyhalov(at)postgrespro(dot)ru>, Michael Banck <michael(dot)banck(at)credativ(dot)de>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com> |
| Subject: | Re: [Commitfest 2022-07] Patch Triage: Needs Review, Part 1 |
| Date: | 2022-07-28 21:50:56 |
| Message-ID: | 3558828.1659045056@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Jacob Champion <jchampion(at)timescale(dot)com> writes:
> Next up is the large list of Needs Review. This part 1 should include
> entries as old or older than seven commitfests running.
I'm just commenting on a couple that I've been involved with.
> = Stalled Patches, Recommend Return =
> - Fix up partitionwise join on how equi-join conditions between the
> partition keys are identified
> https://commitfest.postgresql.org/38/2266/
> It looks like this one was Returned with Feedback but did not actually
> have feedback, which may have caused confusion. (Solid motivation for a
> new close status.) I don't think there's been any review since 2020.
Yeah, there was an earlier discussion of this same patch in some
previous CF-closing thread, IIRC, but I can't find that right now.
I think it basically is stuck behind the outer-join-variables work
I'm pursuing at https://commitfest.postgresql.org/39/3755/ ... and
when/if that lands, the present patch probably won't be anywhere
near what we want anyway. +1 for RWF.
> = Stalled Patches, Need Help =
> - Fix behavior of geo_ops when NaN is involved
> https://commitfest.postgresql.org/38/2710/
> Stuck in a half-committed state, which is tricky. Could maybe use a
> reframing or recap (or a new thread?).
We fixed a couple of easy cases but then realized that the hard cases
are hard. I don't have much faith that the current patch is going to
lead to anything committable, and it doesn't look like anyone has the
appetite to put in a lot of work on the topic. I'd vote for RWF.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-07-28 21:57:12 | Re: standby recovery fails (tablespace related) (tentative patch and discussion) |
| Previous Message | Nathan Bossart | 2022-07-28 21:34:23 | Re: optimize lookups in snapshot [sub]xip arrays |