Re: backup manifests

From: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: David Steele <david(at)pgmasters(dot)net>, Andres Freund <andres(at)anarazel(dot)de>, Noah Misch <noah(at)leadboat(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Suraj Kharage <suraj(dot)kharage(at)enterprisedb(dot)com>, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>, Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com>, Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com>, Tels <nospam-pg-abuse(at)bloodgate(dot)com>, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>
Subject: Re: backup manifests
Date: 2020-04-23 02:33:46
Message-ID: 353d360a-0286-fda0-2de0-7f888a8ee323@oss.nttdata.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2020/04/23 1:28, Robert Haas wrote:
> On Wed, Apr 22, 2020 at 12:21 PM Fujii Masao
> <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
>> I found three minor issues in pg_verifybackup.
>>
>> + {"print-parse-wal", no_argument, NULL, 'p'},
>>
>> This is unused option, so this line should be removed.
>>
>> + printf(_(" -m, --manifest=PATH use specified path for manifest\n"));
>>
>> Typo: --manifest should be --manifest-path
>>
>> pg_verifybackup accepts --quiet option, but its usage() doesn't
>> print any message for --quiet option.
>>
>> Attached is the patch that fixes those issues.
>
> Thanks; LGTM.

Thanks for the review! Pushed.

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2020-04-23 02:34:45 Re: Remove non-fast promotion Re: Should we remove a fallback promotion? take 2
Previous Message Kyotaro Horiguchi 2020-04-23 02:27:25 Re: [PATCH] Fix buffer not null terminated on (ecpg lib)