From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: [HACKERS] Preserving param location |
Date: | 2021-07-14 18:02:18 |
Message-ID: | 3521849.1626285738@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Julien Rouhaud <rjuju123(at)gmail(dot)com> writes:
> On Tue, Jul 13, 2021 at 07:01:24PM -0400, Tom Lane wrote:
>> So I'm not really convinced that there's a fully-baked use case
>> here, and would like more detail about how you hope to use the
>> location value.
> As I said I have no doubt that there are other cases which are currently not
> correctly handled, but that's not what I'm trying to fix. I just want to treat
> parameterized queries the same way as regular queries, thus fixing one obvious
> and frequent case (for which some user did complain), hoping that it will on
> its own already help many users.
Hm. I guess this point (i.e. that the Param substitution should result
in the identical plan tree as writing a literal constant would have)
has some force. I still feel like your application is pretty shaky,
but I don't really have any ideas about feasible ways to make it better.
Will push the patch.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Bharath Rupireddy | 2021-07-14 18:08:59 | Remove redundant Assert(PgArchPID == 0); in PostmasterStateMachine |
Previous Message | Alvaro Herrera | 2021-07-14 18:02:04 | Re: CREATE TABLE .. PARTITION OF fails to preserve tgenabled for inherited row triggers |