| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Winter Loo <winterloo(at)126(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: may be a buffer overflow problem |
| Date: | 2024-06-18 02:42:41 |
| Message-ID: | 3520930.1718678561@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2024-06-17 23:52:54 +0200, Daniel Gustafsson wrote:
>> Since sqlca is, according to our docs, present in other database systems we
>> should probably keep it a 5-char array for portability reasons. Adding a
>> padding character should be fine though.
> How about, additionally, adding __attribute__((nonstring))? Wrapped in an
> attribute, of course. That'll trigger warning for many unsafe uses, like
> strlen().
What I was advocating for is that we make it *safe* for strlen, not
that we double down on awkward, non-idiomatic, unsafe coding
practices.
Admittedly, I'm not sure how we could persuade compilers that
a char[5] followed by a char field is a normal C string ...
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2024-06-18 02:49:54 | Re: Better error message when --single is not the first arg to postgres executable |
| Previous Message | Andres Freund | 2024-06-18 02:35:32 | Re: may be a buffer overflow problem |