| From: | Christian Ullrich <chris(at)chrullrich(dot)net> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | pgsql-committers <pgsql-committers(at)postgresql(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Add putenv support for msvcrt from Visual Studio 2013 |
| Date: | 2016-04-25 13:27:50 |
| Message-ID: | 34dd7956-3324-0305-288d-edc7d56fba76@chrullrich.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
* Magnus Hagander wrote:
> On Sun, Apr 24, 2016 at 9:56 PM, Christian Ullrich <chris(at)chrullrich(dot)net>
> wrote:
>
>> * Magnus Hagander wrote:
>>
>> Add putenv support for msvcrt from Visual Studio 2013
>> http://git.postgresql.org/pg/commitdiff/9f633b404cb3be6139f8dfdea00538489ffef9ab
>> Just noticed something. This DLL detection by name has never worked in
>> debug builds where the DLL names end in "d". Is that important?
> That's an interesting point. I guess our release builds are never with
> debugging info - but could it make the buildfarm "wrong"?
>
> Fixing it should probably be as easy as trying each dll with the specified
> name and also with a "d" as a suffix?
I think so, yes.
Personally, I would have expected that at least the debug/release DLLs
of a single CRT version would somehow share their environment, but I
tried it and they don't.
--
Christian
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2016-04-25 13:46:38 | Re: [COMMITTERS] pgsql: Convert the PGPROC->lwWaitLink list into a dlist instead of open |
| Previous Message | Magnus Hagander | 2016-04-25 13:24:44 | Re: pgsql: Add putenv support for msvcrt from Visual Studio 2013 |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2016-04-25 13:32:07 | Re: snapshot too old, configured by time |
| Previous Message | Magnus Hagander | 2016-04-25 13:24:44 | Re: pgsql: Add putenv support for msvcrt from Visual Studio 2013 |