| From: | Teodor Sigaev <teodor(at)sigaev(dot)ru> |
|---|---|
| To: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com> |
| Cc: | Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru>, Oleg Bartunov <obartunov(at)postgrespro(dot)ru>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: json(b)_to_tsvector with numeric values |
| Date: | 2018-04-04 14:09:03 |
| Message-ID: | 34d4eb10-7b77-eb66-6198-89900a11fb56@sigaev.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>> Hm, seems, it's useful feature, but I suggest to make separate function
>> jsonb_any_to_tsvector and add support for boolean too (if you know better
>> name for function, do not hide it). Changing behavior of existing function
>> is not obvious for users and, seems, should not backpatched.
>
> What do you think about having not a separate function, but a flag argument to
> the existing one (like `create` in `jsonb_set`), that will have false as
> default value? The result would be the same, but without an extra function with
> almost the same implementation.
tsvector jsonb_to_tsvector(jsonb[, bool]) ?
Agreed. Second arg should be optional.
--
Teodor Sigaev E-mail: teodor(at)sigaev(dot)ru
WWW: http://www.sigaev.ru/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Craig Ringer | 2018-04-04 14:09:09 | Re: PostgreSQL's handling of fsync() errors is unsafe and risks data loss at least on XFS |
| Previous Message | Craig Ringer | 2018-04-04 14:00:15 | Re: PostgreSQL's handling of fsync() errors is unsafe and risks data loss at least on XFS |