| From: | Alex Hunsaker <badalex(at)gmail(dot)com> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Tim Bunce <Tim(dot)Bunce(at)pobox(dot)com>, "David E(dot) Wheeler" <david(at)kineticode(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Miscellaneous changes to plperl [PATCH] |
| Date: | 2010-01-24 01:38:34 |
| Message-ID: | 34d269d41001231738n3cc9380dw9f037ec5e1bd5183@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Jan 23, 2010 at 16:26, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>
>
> Tim Bunce wrote:
>>>
>>> - } keys %$imports;
>>> + } sort keys %$imports;
>>>
>>
>> Ok, good.
>>
>>
>>>
>>> - my $funcsrc;
>>> - $funcsrc .= qq[ undef *{'$name'}; *{'$name'} = sub { $BEGIN $prolog
>>> $src } ];
>>> - #warn "plperl mkfuncsrc: $funcsrc\n";
>>> - return $funcsrc;
>>> + return qq[ undef *{'$name'}; *{'$name'} = sub { $BEGIN $prolog $src }
>>> ];
>>>
>>>
>>
>> Ok. (I don't think that'll clash with any later patches.)
>>
>>
>> So, what now? Should I resend the patch with the two 'ok' changes above
>> included, or can the committer make those very minor changes?
>>
>>
>>
>
> I'll pick these up, if Alex marks it ready for committer.
Done.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alex Hunsaker | 2010-01-24 01:40:03 | Re: Miscellaneous changes to plperl [PATCH] |
| Previous Message | KaiGai Kohei | 2010-01-24 01:33:40 | Re: restructuring "alter table" privilege checks (was: remove redundant ownership checks) |