| From: | Alex Hunsaker <badalex(at)gmail(dot)com> |
|---|---|
| To: | Grzegorz Jaskiewicz <gj(at)pointblue(dot)com(dot)pl> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, Greg Stark <gsstark(at)mit(dot)edu>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: clang's static checker report. |
| Date: | 2009-08-27 17:41:05 |
| Message-ID: | 34d269d40908271041q56667b98jb8500aa12a61eb14@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Aug 27, 2009 at 06:39, Grzegorz Jaskiewicz<gj(at)pointblue(dot)com(dot)pl> wrote:
> heh, sorry folks for the noise again :/
>
> There was a fair amount of false positives there - due to nature of Assert()
> macro. Mainly, since assert_enabled is a runtime variable, not a macro
> (which I sadly overlooked).
>
> So, hardcoding it to (1) (using CPP) removed quite few false positives.
>
> New results at:
>
> http://zlew.org/postgresql_static_check/scan-build-2009-08-27-4/
> archive at:
> http://zlew.org/postgresql_static_check/postgresql_static_check_27thAugust2009_2.tar.xz
>
> Please tell me, if you think that it can be improved more.
Looks like your still missing ExitPostmaster(1) see
http://zlew.org/postgresql_static_check/scan-build-2009-08-27-4/report-iqR9gz.html#EndPath.
and maybe ereport(ERROR) ?
see http://zlew.org/postgresql_static_check/scan-build-2009-08-27-4/report-gkkK9S.html#EndPath
it calls report_untranslatable_char() which in turn calls ereport(ERROR)
(do you have to mark every function that calls ereport(ERROR) as one
that exits?)
:)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2009-08-27 17:59:01 | Re: clang's static checker report. |
| Previous Message | Robert Haas | 2009-08-27 17:12:20 | Re: [pgsql-hackers] Daily digest v1.9418 (15 messages) |