Re: [HACKERS] Patch for Prevent pg_dump/pg_restore from being affected by statement_timeout

From: "Alex Hunsaker" <badalex(at)gmail(dot)com>
To: "Alvaro Herrera" <alvherre(at)commandprompt(dot)com>, "Pg Patches" <pgsql-patches(at)postgresql(dot)org>
Cc: "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>, "Andrew Dunstan" <andrew(at)dunslane(dot)net>, "Greg Sabino Mullane" <greg(at)turnstep(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [HACKERS] Patch for Prevent pg_dump/pg_restore from being affected by statement_timeout
Date: 2008-04-16 23:21:35
Message-ID: 34d269d40804161621q8aa544dh6d10ab7a2c934d9e@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

On Wed, Apr 16, 2008 at 4:54 PM, Alvaro Herrera
<alvherre(at)commandprompt(dot)com> wrote:
> Joshua D. Drake escribió:
>
> > That is an interesting idea. Something like:
> >
> > pg_restore -E "SET STATEMENT_TIMEOUT=0; SET MAINTENANCE_WORK_MEM=1G" ?
>
> We already have it -- it's called PGOPTIONS.
>

Ok but is not the purpose of the patch to turn off statement_timeout
by *default* in pg_restore/pg_dump?

Here is an updated patch for I posted above (with the command line
option --use-statement-timeout) for pg_dump and pg_restore.

(sorry If I hijacked your patch Josh :) )

Attachment Content-Type Size
pg_dump_restore_statement_timeout.diff application/octet-stream 5.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Brendan Jurd 2008-04-16 23:37:33 Re: printTable API (was: Show INHERIT in \du)
Previous Message Stephen Denne 2008-04-16 23:19:49 Re: count(*) performance improvement ideas

Browse pgsql-patches by date

  From Date Subject
Next Message Brendan Jurd 2008-04-16 23:37:33 Re: printTable API (was: Show INHERIT in \du)
Previous Message Alvaro Herrera 2008-04-16 22:54:49 Re: Patch for Prevent pg_dump/pg_restore from being affected by statement_timeout