Re: [HACKERS] inlining

From: "Vadim B(dot) Mikheev" <vadim(at)sable(dot)krasnoyarsk(dot)su>
To: Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us>
Cc: PostgreSQL-development <hackers(at)postgreSQL(dot)org>
Subject: Re: [HACKERS] inlining
Date: 1998-01-30 06:53:44
Message-ID: 34D178F8.946D669D@sable.krasnoyarsk.su
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian wrote:
>
> Let me add, I am not inlining all the functions, but only the top part
> of them that deals with cachoffsets and nulls. These are the easy ones,
> and the ones that get used most often.

fastgetattr() is called from a HUNDREDS places - I'm not sure that
this is good idea.

I suggest to inline _entire_ body of this func in the
execQual.c:ExecEvalVar() - Executor uses _only_ ExecEvalVar() to get
data from tuples.

(We could #define FASTGETATTR macro and re-write fastgetattr() as just
this macro "call".)

I don't know should we follow the same way for fastgetiattr() or not...

Vadim

In response to

  • inlining at 1998-01-30 06:01:41 from Bruce Momjian

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Vadim B. Mikheev 1998-01-30 06:57:59 Re: [HACKERS] inlining
Previous Message teunis 1998-01-30 06:50:40 CVS tonight (10pm MST)