Re: Find dangling membership roles in pg_dumpall

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Andreas 'ads' Scherbaum <ads(at)pgug(dot)de>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Find dangling membership roles in pg_dumpall
Date: 2023-04-26 12:29:00
Message-ID: 34D07177-7F22-4CBC-B068-437C62F017FD@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 26 Apr 2023, at 13:02, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>> On 26 Apr 2023, at 12:18, Andreas 'ads' Scherbaum <ads(at)pgug(dot)de> wrote:

>> The attached patch fixes this problem, and updates prev_remaining inside
>> the loop.
>
> Nice catch, that indeed seems like a proper fix. This was introduced in
> ce6b672e44 and so doesn't need a backpatch.

Pushed, but without the comment extension as I felt the existing comment aptly
discussed the codepath. Thanks!

--
Daniel Gustafsson

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2023-04-26 12:31:38 Re: Option to not use ringbuffer in VACUUM, using it in failsafe mode
Previous Message Aleksander Alekseev 2023-04-26 12:07:18 Re: [PATCH] Extend the length of BackgroundWorker.bgw_library_name