Re: Memory leak fix in psql

From: Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>
To: "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Memory leak fix in psql
Date: 2022-07-19 16:43:21
Message-ID: 349B19E2-33D2-4BC7-A291-6C0FA2460FB2@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Jul 19, 2022, at 2:02 AM, tanghy(dot)fnst(at)fujitsu(dot)com wrote:
>
> I think there is a newly introduced memory leak in your patch d2d3547.

I agree. Thanks for noticing, and for the patch!

> Try to fix it in the attached patch.
> Kindly to have a check.

This looks ok, but comments down-thread seem reasonable, so I suspect a new patch will be needed. Would you like to author it, or would you prefer that I, as the guilty party, do so?


Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2022-07-19 16:43:55 Re: Autovacuum worker spawning strategy
Previous Message Tom Lane 2022-07-19 16:39:43 Re: [PATCH] Log details for client certificate failures