| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Richard Guo <guofenglinux(at)gmail(dot)com> |
| Cc: | David Rowley <dgrowleyml(at)gmail(dot)com>, Alexander Lakhin <exclusion(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Properly pathify the union planner |
| Date: | 2024-03-28 02:56:35 |
| Message-ID: | 3485967.1711594595@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Richard Guo <guofenglinux(at)gmail(dot)com> writes:
> On Wed, Mar 27, 2024 at 6:34 PM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
>> The attached is roughly what I had in mind. I've not taken the time
>> to see what comments need to be updated, so the attached aims only to
>> assist discussion.
> I like this idea.
I haven't studied the underlying problem yet, so I'm not quite
buying into whether we need this struct at all ... but assuming
we do, I feel like "PlannerContext" is a pretty poor name.
There's basically nothing to distinguish it from "PlannerInfo",
not to mention that readers would likely assume it's a memory
context of some sort.
Perhaps "SubqueryContext" or the like would be better? It
still has the conflict with memory contexts though.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2024-03-28 02:59:42 | Re: Add pg_basetype() function to obtain a DOMAIN base type |
| Previous Message | jian he | 2024-03-28 02:54:08 | Re: Add pg_basetype() function to obtain a DOMAIN base type |