| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Albe Laurenz <laurenz(dot)albe(at)wien(dot)gv(dot)at>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Index created in BEFORE trigger not updated during INSERT |
| Date: | 2017-06-04 16:10:10 |
| Message-ID: | 3483.1496592610@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
> The patch looks good to me, could you add a regression test?
Done, thanks for the review. I stuck the test into triggers.sql,
which is not completely on point since there are other ways to get
to this error. But if we're thinking of it as a framework for testing
other CheckTableNotInUse cases then adding it to e.g. create_index.sql
doesn't seem right either.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mengxing Liu | 2017-06-04 16:27:51 | Re: Re: [GSOC 17] Eliminate O(N^2) scaling from rw-conflict tracking in serializable transactions |
| Previous Message | Sokolov Yura | 2017-06-04 13:10:16 | Re: Fix performance of generic atomics |