| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Laetitia Avrot <laetitia(dot)avrot(at)gmail(dot)com>, Chapman Flack <chap(at)anastigmatix(dot)net>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Vik Fearing <vik(at)postgresfriends(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_dump new feature: exporting functions only. Bad or good idea ? |
| Date: | 2022-03-25 21:54:50 |
| Message-ID: | 3481656.1648245290@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
>> On 25 Mar 2022, at 19:37, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I'd vote for changing the behavior of --table rather than trying to
>> be bug-compatible with this decision.
> Agreed. Question is what to do for "-t pg_class", should we still forbid
> dumping system catalogs when they are pattern matched without wildcard or is
> should that be ok? And should this depend on if "-n pg_catalog" is used?
I don't think there's anything really wrong with just "we won't dump
system objects, full stop"; I don't see much use-case for doing that
except maybe debugging, and even that is a pretty thin argument.
However, a possible compromise is to say that we act as though
--exclude-schema=pg_catalog is specified unless you explicitly
override that with "--schema=pg_catalog". (And the same for
information_schema, I suppose.) This might be a bit hacky to
implement :-(
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-03-25 22:00:22 | Re: [PATCH] Enable SSL library detection via PQsslAttribute |
| Previous Message | Thomas Munro | 2022-03-25 21:52:03 | Re: pgsql: Add 'basebackup_to_shell' contrib module. |