| From: | ocean_li_996 <ocean_li_996(at)163(dot)com> |
|---|---|
| To: | "Ajin Cherian" <itsajin(at)gmail(dot)com> |
| Cc: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re:Re: Fix logical decoding not track transaction during SNAPBUILD_BUILDING_SNAPSHOT |
| Date: | 2026-01-28 19:06:55 |
| Message-ID: | 34704d62.9b86.19c0600683b.Coremail.ocean_li_996@163.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Ajin,
At 2026-01-28 11:32:41, "Ajin Cherian" <itsajin(at)gmail(dot)com> wrote:
>I agree with your analysis and approach, but when I tried out the
>patch (applying patch 0002 for the tests and patch 0004), I see the
>tests in contrib/test_decoding failing.
>Similarly, applying patch 0002 and 0003 also results in the tests
>failing. So, I am not sure how your minimal fix fixes the problem. Am
>I doing something wrong?
>Does patch 0003 and 0004 have to be applied on top of 0001? That
>doesn't seem to be the case, as both make the same code change and
>don't apply cleanly.
0002 patch is only a test case. And 0001, 0003 and 0004 are independt fix patch.
I appied 0002 + 0003 and 0002 + 0004 separately in master. And both the tests in
contrib/test_decoding were passed. Can you provide more details about the failed
tests(such as which tests and the diff between expected and ressult).
Regards
Haiyang Li
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Steve Chavez | 2026-01-28 19:19:31 | Re: Add SECURITY_INVOKER_VIEWS option to CREATE DATABASE |
| Previous Message | Greg Burd | 2026-01-28 19:04:46 | Re: Refactor how we form HeapTuples for CatalogTuple(Insert|Update) |