Re: PL/Python patch for Universal Newline Support

From: "Andrew Dunstan" <andrew(at)dunslane(dot)net>
To: <mike(at)fuhr(dot)org>
Cc: <tgl(at)sss(dot)pgh(dot)pa(dot)us>, <neilc(at)samurai(dot)com>, <pgsql-patches(at)postgresql(dot)org>
Subject: Re: PL/Python patch for Universal Newline Support
Date: 2005-03-21 08:50:20
Message-ID: 3470.24.211.165.134.1111395020.squirrel@www.dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Michael Fuhr said:
> On Mon, Mar 21, 2005 at 03:02:57AM -0500, Tom Lane wrote:
>>
>> One thing that needs some thought is how you are going to test this
>> robustly. I'd not feel any great deal of confidence in a test that
>> expects that we can push \r\n sequences into CVS and expect them to
>> survive unmodified into distributed filesets. Every so often someone
>> commits a DOS-newlines file into CVS, and they hear about it PDQ...
>
> We're testing what happens when \r gets into prosrc, right? Shouldn't
> creating the function with \r in single quotes instead of dollar
> quotes work, as in the tests I showed in my original submission?
>

Yes - also worked in testing CSV multiline support - see copy regression
test.
cheers

andrew

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2005-03-21 15:05:52 Re: PL/Python patch for Universal Newline Support
Previous Message Michael Fuhr 2005-03-21 08:26:53 Re: PL/Python patch for Universal Newline Support