From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
---|---|
To: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Crash when partition column specified twice |
Date: | 2017-04-28 00:38:39 |
Message-ID: | 346223c6-ee7d-feeb-b583-8fc8a5bf7ab7@lab.ntt.co.jp |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2017/04/27 12:36, Amit Langote wrote:
> Noticed that a crash occurs if a column is specified twice when creating a
> partition:
>
> create table p (a int) partition by list (a);
>
> -- crashes
> create table p1 partition of parent (
> a not null,
> a default 1
> ) for values in (1);
>
> The logic in MergeAttributes() that merged partition column options with
> those of the parent didn't properly check for column being specified twice
> and instead tried to delete the same ColumnDef from a list twice, causing
> the crash.
>
> Attached fixes that.
Patch rebased, because of a conflict with b9a3ef55b2.
Thanks,
Amit
Attachment | Content-Type | Size |
---|---|---|
0001-Fix-crash-when-partition-column-specified-twice.patch | text/x-diff | 8.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Masahiko Sawada | 2017-04-28 01:20:48 | Re: Interval for launching the table sync worker |
Previous Message | Neha Khatri | 2017-04-27 22:59:35 | Re: tablesync patch broke the assumption that logical rep depends on? |