Re: A compiling warning in jsonb_populate_record_valid

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Amit Langote <amitlangote09(at)gmail(dot)com>
Cc: Richard Guo <guofenglinux(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: A compiling warning in jsonb_populate_record_valid
Date: 2024-01-25 14:57:32
Message-ID: 345271.1706194652@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Amit Langote <amitlangote09(at)gmail(dot)com> writes:
> On Thu, Jan 25, 2024 at 2:59 PM Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
>> I came across a warning when building master (a044e61f1b) on old GCC
>> (4.8.5).

> Will apply the attached, which does this:

> - return BoolGetDatum(!SOFT_ERROR_OCCURRED(&escontext));
> + return BoolGetDatum(!escontext.error_occurred);

-1 please. We should not break that abstraction for the sake
of ignorable warnings on ancient compilers.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2024-01-25 15:06:41 Re: cleanup patches for incremental backup
Previous Message jian he 2024-01-25 14:39:30 Re: remaining sql/json patches