ReplicationSlotCtl: undefined reference

From: Pavlo Golub <pavlo(dot)golub(at)cybertec(dot)at>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Cc: Craig Ringer <craig(at)2ndquadrant(dot)com>
Subject: ReplicationSlotCtl: undefined reference
Date: 2019-06-11 12:19:43
Message-ID: 345138875.20190611151943@cybertec.at
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Greetings.

Trying to build pg extension I've got error:
```
pglogical_monitoring.o:pglogical_monitoring.c:(.rdata$.refptr.ReplicationSlotCtl[.refptr.ReplicationSlotCtl]+0x0): undefined reference to `ReplicationSlotCtl'
collect2: error: ld returned 1 exit status
```

But according to https://commitfest.postgresql.org/16/1390/ it should
be marked with PGDLLIMPORT.

However checking sources there is no this spec
(https://github.com/postgres/postgres/blob/fff2a7d7bd09db38e1bafc1303c29b10a9805dc0/src/include/replication/slot.h#L172):

```
extern ReplicationSlotCtlData *ReplicationSlotCtl;
```

Am I correct or missing smth?
Craig, it supposed to be your proposal about ReplicationSlotCtl and
patch. Am I right?

--
Kind regards,
Pavlo mailto:pavlo(dot)golub(at)cybertec(dot)at

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2019-06-11 12:27:59 Re: Custom table AMs need to include heapam.h because of BulkInsertState
Previous Message Masahiko Sawada 2019-06-11 12:08:36 Re: Temp table handling after anti-wraparound shutdown (Was: BUG #15840)