Re: [PATCH] The heap_getsysattr function deletes unused parameters

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: lei yang <yanglei(dot)ovo(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] The heap_getsysattr function deletes unused parameters
Date: 2026-07-15 15:53:40
Message-ID: 3441872.1784130820@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

lei yang <yanglei(dot)ovo(at)gmail(dot)com> writes:
> The tupleDesc parameter in the heap_getsysattr function is not used,
> and the TupleDesc structure does not contain system attributes.
> Maybe we can delete the parameter tupleDesc.

I do not think this is a great idea. We don't use the tupdesc today
perhaps, but it's plausible that it'd be needed in the future.
Different table AMs might have different sets of system columns.

Unless you can show a measurable performance gain from this change,
we should leave it alone.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Previous Message lei yang 2026-07-15 15:50:29 [PATCH] The heap_getsysattr function deletes unused parameters