| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Aleksander Alekseev <aleksander(at)timescale(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pg_stop_backup() v2 incorrectly marked as proretset |
| Date: | 2022-03-03 21:40:42 |
| Message-ID: | 3441490.1646343642@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Wed, Mar 2, 2022 at 9:35 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I've not read the whole patch, but this snippet seems fine to me
>> if there's also an #undef at the end of the function.
>> From later emails, it sounds like that's not the common practice in
> similar cases, and I don't personally see the point.
The point is to make it clear that the macro isn't intended to affect
code outside the function. Since C lacks block-scoped macros,
there's no other way to do that.
I concede that a lot of our code is pretty sloppy about this, but
that doesn't make it a good practice.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-03-03 21:45:14 | Re: casting operand to proper type in BlockIdGetBlockNumber |
| Previous Message | Zhihong Yu | 2022-03-03 21:21:39 | Re: casting operand to proper type in BlockIdGetBlockNumber |