Re: [PATCH] Fix compilation of nodeMergejoin.c with EXEC_MERGEJOINDEBUG

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Tatsuya Kawata <kawatatatsuya0913(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Fix compilation of nodeMergejoin.c with EXEC_MERGEJOINDEBUG
Date: 2026-08-16 14:26:33
Message-ID: 343446.1786890393@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Michael Paquier <michael(at)paquier(dot)xyz> writes:
> So question time: Is this debugging code still relevant and wouldn't
> it be better to just remove it?

+1. I'd be inclined to think about removing execdebug.h altogether.
If this style of debug support were really useful, it would have
migrated into more than three kinds of executor node by now.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Erik Rijkers 2026-08-16 14:30:19 pgcrypto.sgml: built in -> built-in
Previous Message Andrey Borodin 2026-08-16 12:23:55 Re: gistkillitems can LP_DEAD-mark the wrong tuples on a rescan