Re: Add bms_offset_members() function for bitshifting Bitmapsets

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: Peter Eisentraut <peter(at)eisentraut(dot)org>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Add bms_offset_members() function for bitshifting Bitmapsets
Date: 2026-04-18 15:09:31
Message-ID: 3432490.1776524971@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> On Thu, 16 Apr 2026 at 07:17, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>> Depending on what you end up doing, maybe a sprinkling of pg_nodiscard
>> could be appropriate.

> Yeah maybe. It wouldn't do any harm, at least.

> I didn't do that in the patch I just sent as it felt like something we
> should do or not do for all the bitmapset functions it's relevant for.

Agreed, seems like it should be a separate patch.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Shruthi Gowda 2026-04-18 16:20:37 Re: [BUG] CRASH: ECPGprepared_statement() and ECPGdeallocate_all() when connection is NULL
Previous Message Alexander Lakhin 2026-04-18 15:00:00 Re: eliminate xl_heap_visible to reduce WAL (and eventually set VM on-access)