| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Inconvenience of pg_read_binary_file() |
| Date: | 2022-07-30 14:24:39 |
| Message-ID: | 342893.1659191079@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> On 2022-Jul-30, Michael Paquier wrote:
>> PG_VERSION would be simpler. Looking at postmaster.pid would require
>> a lookup at external_pid_file, and as it is not set by default you
>> would need to add some extra logic in the tests where
>> external_pid_file = NULL <=> PGDATA/postmaster.pid.
> Hmm, no? as I recall external_pid_file is an *additional* PID file; it
> doesn't supplant postmaster.pid.
Right. postmaster.pid absolutely should be there if the postmaster
is up (and if it ain't, you're going to have lots of other difficulty
in running the regression tests...). It doesn't feel quite as static
as PG_VERSION, though.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-07-30 14:37:55 | Re: standby recovery fails (tablespace related) (tentative patch and discussion) |
| Previous Message | houzj.fnst@fujitsu.com | 2022-07-30 13:29:20 | RE: Functions 'is_publishable_class' and 'is_publishable_relation' should stay together. |