| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, Shinya11(dot)Kato(at)nttdata(dot)com, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: psql - factor out echo code |
| Date: | 2021-07-13 22:16:21 |
| Message-ID: | 3409118.1626214581@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> writes:
> Attached v4 simplifies the format and fixes this one.
I think this goes way way overboard in terms of invasiveness.
There's no need to identify individual call sites of PSQLexec.
We didn't have anything like that level of detail before, and
there has been no field demand for it either. What I had
in mind was basically to identify the call sites of echoQuery,
ie distinguish user commands from psql-generated commands
with labels like "QUERY:" vs "INTERNAL QUERY:". We don't
need to change the APIs of existing functions, I don't think.
It also looks like a mess from the translatibility standpoint.
You can't expect "%s QUERY" to be a useful thing for translators.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zhihong Yu | 2021-07-13 22:21:18 | Re: closing heap relation |
| Previous Message | Zhihong Yu | 2021-07-13 22:13:57 | closing heap relation |