| From: | Alexander Lakhin <exclusion(at)gmail(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: fix tablespace handling in pg_combinebackup |
| Date: | 2024-04-21 12:00:00 |
| Message-ID: | 33ae66c2-a9a1-db1c-9361-79d55842430a@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello Thomas and Robert,
20.04.2024 08:56, Thomas Munro wrote:
> ... it still broke[4]. So I'm not sure what's going on...
>
From what I can see, the following condition (namely, -l):
if ($path =~ /^pg_tblspc\/(\d+)$/ && -l "$backup_path/$path")
{
push @tsoids, $1;
return 0;
}
is false for junction points on Windows (cf [1]), but the target path is:
Directory of
C:\src\postgresql\build\testrun\pg_combinebackup\002_compare_backups\data\t_002_compare_backups_primary_data\backup\backup1\pg_tblspc
04/21/2024 02:05 PM <DIR> .
04/21/2024 02:05 PM <DIR> ..
04/21/2024 02:05 PM <JUNCTION> 16415 [\??\C:\Users\ADMINI~1\AppData\Local\Temp\xXMfNDMCot\ts1backup]
[1] https://www.perlmonks.org/?node_id=1223819
Best regards,
Alexander
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2024-04-21 12:35:15 | Re: createdb compares strategy as case-sensitive |
| Previous Message | Jelte Fennema-Nio | 2024-04-21 11:52:36 | Re: Support a wildcard in backtrace_functions |