From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Christoph Berg <myon(at)debian(dot)org> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Encoding of src/timezone/tznames/Europe.txt |
Date: | 2020-07-16 14:24:29 |
Message-ID: | 3356880.1594909469@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Christoph Berg <myon(at)debian(dot)org> writes:
> Is there any reason why src/timezone/tznames/Europe.txt is encoded in
> latin1 and not utf-8?
> The offending lines are these timezones:
> MESZ 7200 D # Mitteleuropäische Sommerzeit (German)
> # (attested in IANA comments though not their code)
> MEZ 3600 # Mitteleuropäische Zeit (German)
> # (attested in IANA comments though not their code)
> It's not important for anything, just general sanity. (Spotted by
> Debian's package checker, lintian.)
Hm. TBH, my first reaction is "let's lose the accents". I agree that
it's not great to be installing files that are encoded in latin1, but
it might not be great to be installing files that are encoded in utf8
either. Aren't we better off insisting that these files be plain ascii?
I notice that the copies of these lines in src/timezone/tznames/Default
seem to be ascii-ified already. Haven't traced the git history,
but I bet somebody fixed Default without noticing the other copy.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | David G. Johnston | 2020-07-16 14:45:11 | Re: How to identify trigger is called from the node where row is created |
Previous Message | Amit Langote | 2020-07-16 14:14:40 | Re: [PATCH] Performance Improvement For Copy From Binary Files |