| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Martijn van Oosterhout <kleptog(at)svana(dot)org> |
| Cc: | Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Stefan Kaltenbrunner <stefan(at)kaltenbrunner(dot)cc>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: seahorse again failing |
| Date: | 2006-08-22 15:06:09 |
| Message-ID: | 3353.1156259169@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Martijn van Oosterhout <kleptog(at)svana(dot)org> writes:
> Would it be possible to get errcode_for_file_access() to report the
> results of GetLastError() for windows, or would that roduce spurious
> results. At DEBUG lavel maybe?
It would have to be at LOG level, because otherwise it wouldn't get
logged at all with the default settings that the buildfarm is using.
Also, I think that errcode_for_file_access() may run too late, ie,
we couldn't be sure that we were looking at the same value of
GetLastError. This could be dealt with by saving GetLastError into
the error data structure at the same place we save errno, but that's
starting to get a bit invasive for a temporary-investigation kluge.
BTW, whoever writes this needs to check that it doesn't change the
default regression test results ...
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alban Hertroys | 2006-08-22 15:07:19 | Re: Queries joining views |
| Previous Message | Tom Lane | 2006-08-22 14:48:07 | Re: Queries joining views |