| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Dhanaraj M - Sun Microsystems <dhanaraj(dot)m(at)mail-apac(dot)sun(dot)com> |
| Cc: | pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: Patch for bug #2073 (Can't drop sequence when created via SERIAL column) |
| Date: | 2006-04-11 03:13:59 |
| Message-ID: | 3350.1144725239@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Dhanaraj M - Sun Microsystems <dhanaraj(dot)m(at)mail-apac(dot)sun(dot)com> writes:
> I fixed the above bug. I attach the patch here. Please review and
> acknowledge me.
> Bug details
> ========
> BUG #2073: Can't drop sequence when created via SERIAL column
That isn't a bug, and this "fix" is not appropriate. See eg Bruce's
response to that bug report:
http://archives.postgresql.org/pgsql-bugs/2005-11/msg00304.php
I speculated a bit ago (can't find it in the archives at the moment)
that we should abandon the hidden dependency altogether, and go back to
having SERIAL just create the sequence and the default expression.
Another idea that might be worth exploring is to link the sequence to
the default expression rather than to the table column itself. But
randomly dropping the dependency is not the answer.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dhanaraj M - Sun Microsystems | 2006-04-11 07:04:37 | Re: Patch for bug #2073 (Can't drop sequence when created |
| Previous Message | Tom Lane | 2006-04-11 02:35:44 | Re: schema-qualified SET CONSTRAINTS |