| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Unify drop-by-OID functions |
| Date: | 2020-05-01 14:39:34 |
| Message-ID: | 331d9661-1743-857f-1cbb-d5728bcd62cb@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
[proposal for PG 14]
There are a number of Remove${Something}ById() functions that are
essentially identical in structure and only different in which catalog
they are working on. This patch refactors this to be one generic
function. The information about which oid column, index, etc. to use
was already available in ObjectProperty for most catalogs, in a few
cases it was easily added.
Conceivably, this could be taken further by categorizing more special
cases as ObjectProperty fields or something like that, but this seemed
like a good balance.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Unify-drop-by-OID-functions.patch | text/plain | 38.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2020-05-01 14:50:18 | Re: Unify drop-by-OID functions |
| Previous Message | David Steele | 2020-05-01 13:26:40 | Re: do {} while (0) nitpick |