Re: Re: [COMMITTERS] pgsql: Initialise perl library as documented in perl API.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: [COMMITTERS] pgsql: Initialise perl library as documented in perl API.
Date: 2009-06-05 14:03:25
Message-ID: 3310.1244210605@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> I think we need to float a bug upstream to the perl guys on this, but as
> a holding position I suggest that we alter the #ifdef test to avoid
> calling PERL_SYS_INIT3() where MYMALLOC is defined.

+1 on both.

> BTW, it's not caused by passing NULL as the third argument of
> PERL_SYS_INIT3() - changing that was the first thing I tried.

Nonetheless, that compiler warning is pretty ugly; please do something
about it. I concur with your feeling that setting up a dummy empty
environment array is probably the safest thing to do.

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message User Dim 2009-06-05 18:18:28 prefix - prefix: Preparing for 1.0, Makefile has hard coded version
Previous Message Bruce Momjian 2009-06-05 13:53:53 Re: Re: [COMMITTERS] pgsql: Initialise perl library as documented in perl API.

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2009-06-05 14:11:27 8.4 release schedule: RC1 next week
Previous Message Bruce Momjian 2009-06-05 13:53:53 Re: Re: [COMMITTERS] pgsql: Initialise perl library as documented in perl API.