Re: Remove some redundant set_cheapest() calls

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Richard Guo <guofenglinux(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Remove some redundant set_cheapest() calls
Date: 2024-03-27 14:59:06
Message-ID: 3305402.1711551546@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Richard Guo <guofenglinux(at)gmail(dot)com> writes:
> On Wed, Mar 27, 2024 at 4:06 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I'm less convinced about changing this. I'd rather keep it consistent
>> with mark_dummy_rel.

> Hm, I wonder if we should revise the comment there that states "but not
> when called from elsewhere", as it does not seem to be true.

I'd be okay with wording like "This is redundant in current usage
because set_rel_pathlist will do it later, but it's cheap so we keep
it for consistency with mark_dummy_rel". What do you think?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2024-03-27 15:01:28 Re: Possibility to disable `ALTER SYSTEM`
Previous Message Tom Lane 2024-03-27 14:54:05 Re: pg_upgrade failing for 200+ million Large Objects