| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Richard Guo <guofenglinux(at)gmail(dot)com> |
| Cc: | David Rowley <dgrowleyml(at)gmail(dot)com>, 邱宇航 <iamqyh(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Inconsistent Behavior of GROUP BY ROLLUP in v17 vs master |
| Date: | 2025-10-20 16:27:58 |
| Message-ID: | 329840.1760977678@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I wrote:
> I like the concept here, but not so much the details. Pulling
> expand_grouping_sets out of preprocess_grouping_sets feels weird.
> I guess it's all right given that preprocess_grouping_sets doesn't
> manipulate the parse tree otherwise, but you didn't update the comment
> for preprocess_grouping_sets. Also it might be a good idea to have a
> test case demonstrating why v2 wasn't good enough.
Here's a v4 with some concrete suggestions for comment changes,
plus the extra test case. (I did some tiny cosmetic fooling with
preprocess_grouping_sets too, because the order of its initial
operations seemed quite weird to me.)
regards, tom lane
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-Fix-pushdown-of-degenerate-HAVING-clauses.patch | text/x-diff | 9.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Arseniy Mukhin | 2025-10-20 16:43:27 | Re: Optimize LISTEN/NOTIFY |
| Previous Message | Viktor Holmberg | 2025-10-20 16:00:43 | Re: Docs and tests for RLS policies applied by command type |