Re: Exposing the stats snapshot timestamp to SQL

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Matt Kelly <mkellycs(at)gmail(dot)com>
Cc: Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Exposing the stats snapshot timestamp to SQL
Date: 2015-01-30 05:07:22
Message-ID: 32724.1422594442@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

Matt Kelly <mkellycs(at)gmail(dot)com> writes:
> On Thu, Jan 29, 2015 at 8:42 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> ... or double. Have you checked that the code behaves properly with
>> --disable-integer-timestamps?

> I presume you meant --disable-integer-datetimes. I just ran that test case
> now, all set.

Right, my own sloppiness there.

> For my own edification, was there really any risk of something so trivial
> breaking due to that setting, or was it just for completeness? (which is a
> perfectly valid reason)

I hadn't looked at your code at that point, and now that I have, I agree
it's unlikely to have had a problem with this. Still, it's a good thing
to check, particularly considering the lack of buildfarm coverage of this
option :-(.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Matt Kelly 2015-01-30 05:27:01 Re: Exposing the stats snapshot timestamp to SQL
Previous Message Matt Kelly 2015-01-30 04:35:38 Re: Exposing the stats snapshot timestamp to SQL