| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, Vladimir Sitnikov <sitnikov(dot)vladimir(at)gmail(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Query cancel seems to be broken in master since Oct 17 |
| Date: | 2016-10-18 14:40:55 |
| Message-ID: | 32574.1476801655@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I wrote:
> The cleanest fix might be to change those various "long" variables
> to uint32. You'd have to think about how to handle the ntohl/htonl
> calls that are used on them, though.
Or actually, no, you wouldn't have to think very hard. I was supposing
that those calls were declared to traffic in "long"s, but they aren't
and never have been, at least not since SUSv2:
uint32_t htonl(uint32_t hostlong);
uint16_t htons(uint16_t hostshort);
uint32_t ntohl(uint32_t netlong);
uint16_t ntohs(uint16_t netshort);
So s/long/uint32/ would probably fix it just fine.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andreas Joseph Krogh | 2016-10-18 14:51:54 | Re: Move pg_largeobject to a different tablespace *without* turning on system_table_mods. |
| Previous Message | Euler Taveira | 2016-10-18 14:26:37 | Re: Move pg_largeobject to a different tablespace *without* turning on system_table_mods. |