Re: A small bug in gram.y

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
Cc: Gokulakannan Somasundaram <gokul007(at)gmail(dot)com>, pgsql-hackers list <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: A small bug in gram.y
Date: 2009-11-03 14:38:11
Message-ID: 3251.1257259091@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> writes:
> Here's an example that exercises those paths:

> postgres=# SELECT 'aa' NOT SIMILAR TO 123;
> ERROR: function pg_catalog.similar_escape(integer, unknown) does not exist
> LINE 1: SELECT 'aa' NOT SIMILAR TO 123;
> ^
> HINT: No function matches the given name and argument types. You might
> need to add explicit type casts.
> postgres=# SELECT 'aa' SIMILAR TO 123;
> ERROR: function pg_catalog.similar_escape(integer, unknown) does not exist
> LINE 1: SELECT 'aa' SIMILAR TO 123;
> ^
> HINT: No function matches the given name and argument types. You might
> need to add explicit type casts.
> postgres=#

> I think the former error location is better.

FWIW, I like the second one better, and if you check around you'll find
that it matches most other similar stuff, eg

regression=# select 12 like 34;
ERROR: operator does not exist: integer ~~ integer
LINE 1: select 12 like 34;
^
HINT: No operator matches the given name and argument type(s). You might need to add explicit type casts.

I think the current coding probably is just a typo, but hadn't gotten
around to doing anything about it.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2009-11-03 14:41:30 Re: new version of PQconnectdb was:(Re: [HACKERS] Determining client_encoding from client locale)
Previous Message Tom Lane 2009-11-03 14:32:26 Re: new version of PQconnectdb was:(Re: [HACKERS] Determining client_encoding from client locale)