Shawn Debnath <sdn(at)amazon(dot)com> writes:
> Good catch. Question is, are the users aware of the requirement to do a
> manual fsync if they flip the fsync GUC off and then on? Should we do
> this on their behalf to make a good faith attempt to ensure things are
> flushed properly via an assign hook?
No. Or at least, expecting that you can do that from an assign hook
is impossibly wrong-headed. GUC assign hooks can't have failure modes.
regards, tom lane