| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | John Naylor <john(dot)naylor(at)enterprisedb(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, "Shinoda, Noriyoshi (PN Japan FSIP)" <noriyoshi(dot)shinoda(at)hpe(dot)com>, Jacob Champion <jchampion(at)timescale(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Subject: | Re: Improve logging when using Huge Pages |
| Date: | 2022-11-07 15:56:16 |
| Message-ID: | 3239882.1667836576@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2022-11-06 14:04:29 +0700, John Naylor wrote:
>> I think the best thing to do is change huge_pages='on' to log a WARNING and
>> fallback to regular pages if the mapping fails.
> I am strongly opposed to making 'on' fall back to not using huge pages. That's
> what 'try' is for.
Agreed --- changing "on" to be exactly like "try" isn't an improvement.
If you want "try" semantics, choose "try".
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Erikjan Rijkers | 2022-11-07 15:59:13 | Re: 2022-11-10 release announcement draft |
| Previous Message | Jonathan S. Katz | 2022-11-07 15:51:45 | 2022-11-10 release announcement draft |