Re: Fix XLogFileReadAnyTLI silently applying divergent WAL from wrong timeline

From: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
To: surya poondla <suryapoondla4(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix XLogFileReadAnyTLI silently applying divergent WAL from wrong timeline
Date: 2026-09-04 19:02:33
Message-ID: 3238B48C-91CC-4029-AEEB-59AC561A25B0@yandex-team.ru
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Surya,

On 31 Aug 2026, Surya Poondla wrote:
> Could it be gated on there actually being an older timeline to abandon,
> i.e. only when the eligible entry isn't the last in expectedTLEs?

Thank you for the review. PFA v4.

I first made "not searching older timelines for WAL segment" a
throttled LOG message. Looking at the result, however, it reports an
action recovery deliberately does not take. On reconsideration, it is
better left as a DEBUG1 diagnostic used by the tests. The tests enable
DEBUG1, while normal recovery logs remain unchanged. I also separated
xlogfname from path as suggested and renumbered the tests to 057/058.

Thank you!

Best regards, Andrey Borodin.

Attachment Content-Type Size
v4-0001-Prevent-archive-recovery-from-reading-divergent-WAL.patch application/octet-stream 14.4 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Corey Huinker 2026-09-04 19:07:49 Re: Credits For v19
Previous Message Paul A Jungwirth 2026-09-04 18:52:20 FOR PORTION OF leftovers should fire triggers on the child table