Re: Useless code in ExecInitModifyTable

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Ryan Murphy <ryanfmurphy(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org, Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
Subject: Re: Useless code in ExecInitModifyTable
Date: 2017-09-05 03:56:14
Message-ID: 32275.1504583774@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Ryan Murphy <ryanfmurphy(at)gmail(dot)com> writes:
> I downloaded the latest patch "clean-nodeModifyTable-v2.patch"
> and tried applying it to HEAD using "git apply <patch-name>".

> The only response from git was "fatal: unrecognized input".

FWIW, I find that good ol' patch is much more reliable about applying
patches that didn't come from git itself. In this case

patch -p1 <~../path/to/clean-nodeModifyTable-v2.patch

seems to work without complaint.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2017-09-05 03:59:13 cache lookup errors for missing replication origins
Previous Message Etsuro Fujita 2017-09-05 03:53:00 Re: Partition-wise join for join between (declaratively) partitioned tables