Re: Bogus HAVE_DECL_FOO entries in msvc/Solution.pm

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Subject: Re: Bogus HAVE_DECL_FOO entries in msvc/Solution.pm
Date: 2021-07-13 13:58:09
Message-ID: 3226452.1626184689@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Tue, Jul 13, 2021 at 12:25:06AM -0400, Tom Lane wrote:
>> That's easy enough in v13 and up, which have 8f4fb4c64 so that
>> Solution.pm looks like this. We could make it consistent in older
>> branches by manually hacking pg_config.h.win32 ... but I'm wondering
>> if the smarter plan wouldn't be to back-patch 8f4fb4c64.

> ... I am not sure that the potential maintenance gain is worth
> poking at the stable branches, to be honest.

Fair enough. I wasn't very eager to do the legwork on that, either,
given that the issue is (so far) only cosmetic.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Justin Pryzby 2021-07-13 14:07:55 Re: unnesting multirange data types
Previous Message Peter Eisentraut 2021-07-13 13:55:48 Re: Replace remaining castNode(…, lfirst(…)) and friends calls with l*_node()