| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>, Andres Freund <andres(at)anarazel(dot)de>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: [COMMITTERS] pgsql: Only try to push down foreign joins if the user mapping OIDs mat |
| Date: | 2016-03-14 17:05:48 |
| Message-ID: | 3221.1457975148@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Sun, Mar 13, 2016 at 10:51 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I'm not really sold on enforcing that people create meaningless user
>> mappings. For one thing, they're likely to be sloppy about it, which
>> could lead to latent security problems if the FDW later acquires a
>> concept that user mappings mean something.
> I think we should just fix build_simple_rel() so that it doesn't fail
> if there is no user mapping. It can just set rel->umid to InvalidOid
> in that case, and if necessary we can adjust the code elsewhere to
> tolerate that. This wasn't an intentional behavior change, and I
> think we should just put things back to the way they were.
So, allow rel->umid to be InvalidOid if there's no user mapping, and
when dealing with a join, allow combining when both sides have InvalidOid?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2016-03-14 17:23:17 | Re: Re: [COMMITTERS] pgsql: Only try to push down foreign joins if the user mapping OIDs mat |
| Previous Message | Tom Lane | 2016-03-14 16:52:01 | pgsql: pg_stat_get_progress_info() should be marked STRICT. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Verite | 2016-03-14 17:18:53 | Re: [patch] Proposal for \crosstabview in psql |
| Previous Message | Tom Lane | 2016-03-14 17:04:05 | Re: WIP: Upper planner pathification |